Untie ConsumerRebalanceListener

ods · Oct 22, 2023 · ee1f564 · ee1f564
1 parent c2041d9
commit ee1f564
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 1,472 deletions.
diff --git a/aiokafka/abc.py b/aiokafka/abc.py
@@ -1,8 +1,7 @@
 import abc
-from kafka import ConsumerRebalanceListener as BaseConsumerRebalanceListener
 
 
-class ConsumerRebalanceListener(BaseConsumerRebalanceListener):
+class ConsumerRebalanceListener(abc.ABC):
     """
     A callback interface that the user can implement to trigger custom actions
     when the set of partitions assigned to the consumer changes.

diff --git a/kafka/__init__.py b/kafka/__init__.py
@@ -20,7 +20,6 @@ def emit(self, record):
 
 from kafka.admin import KafkaAdminClient
 from kafka.client_async import KafkaClient
-from kafka.consumer.subscription_state import ConsumerRebalanceListener
 from kafka.conn import BrokerConnection
 from kafka.serializer import Serializer, Deserializer
 from kafka.structs import TopicPartition, OffsetAndMetadata

diff --git a/kafka/consumer/__init__.py b/kafka/consumer/__init__.py
diff --git a/kafka/consumer/subscription_state.py b/kafka/consumer/subscription_state.py
diff --git a/setup.cfg b/setup.cfg
@@ -5,6 +5,7 @@ exclude =
     venv
     __pycache__
     .tox
+    tests/kafka/
 
 [isort]
 line_length=88

diff --git a/tests/kafka/conftest.py b/tests/kafka/conftest.py
@@ -42,14 +42,6 @@ def factory(**broker_params):
         broker.close()
 
 
-@pytest.fixture
-def kafka_client(kafka_broker, request):
-    """Return a KafkaClient fixture"""
-    (client,) = kafka_broker.get_clients(cnt=1, client_id='%s_client' % (request.node.name,))
-    yield client
-    client.close()
-
-
 @pytest.fixture
 def kafka_consumer(kafka_consumer_factory):
     """Return a KafkaConsumer fixture"""

diff --git a/tests/kafka/test_consumer_integration.py b/tests/kafka/test_consumer_integration.py