Correct the hint threshold, and move the thresholds to evaluate.h

Bench: 1741218
official-stockfish · Mar 10, 2024 · 6af79e1 · 6af79e1
1 parent d84ab5f
commit 6af79e1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/evaluate.cpp b/src/evaluate.cpp
@@ -193,8 +193,8 @@ Value Eval::evaluate(const Position& pos, int optimism) {
     assert(!pos.checkers());
 
     int  simpleEval = simple_eval(pos, pos.side_to_move());
-    bool smallNet   = std::abs(simpleEval) > 1139;
-    bool psqtOnly   = std::abs(simpleEval) > 2500;
+    bool smallNet   = std::abs(simpleEval) > NNUE::smallNetThreshold;
+    bool psqtOnly   = std::abs(simpleEval) > NNUE::psqtOnlyThreshold;
 
     int nnueComplexity;
 

diff --git a/src/evaluate.h b/src/evaluate.h
@@ -59,6 +59,8 @@ enum NetSize : int;
 
 using EvalFiles = std::unordered_map<Eval::NNUE::NetSize, EvalFile>;
 
+constexpr inline int smallNetThreshold = 1139, psqtOnlyThreshold = 2500;
+
 EvalFiles load_networks(const std::string&, const OptionsMap&, EvalFiles);
 void      verify(const OptionsMap&, const EvalFiles&);
 

diff --git a/src/nnue/evaluate_nnue.cpp b/src/nnue/evaluate_nnue.cpp
@@ -180,8 +180,8 @@ write_parameters(std::ostream& stream, NetSize netSize, const std::string& netDe
 void hint_common_parent_position(const Position& pos) {
 
     int simpleEvalAbs = std::abs(simple_eval(pos, pos.side_to_move()));
-    if (simpleEvalAbs > 1050)
-        featureTransformerSmall->hint_common_access(pos, simpleEvalAbs > 2500);
+    if (simpleEvalAbs > smallNetThreshold)
+        featureTransformerSmall->hint_common_access(pos, simpleEvalAbs > psqtOnlyThreshold);
     else
         featureTransformerBig->hint_common_access(pos, false);
 }