Assorted cleanups #5046
Closed
Assorted cleanups #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I pull requested some cleanups here Disservin#29 |
|
i suggest renaming simpleEval to materialImbalance since its no longer its own evaluation function. this would help reduce confusion as seen here: https://discord.com/channels/435943710472011776/1032922913499783169/1204869114091278376 |
Viren6
pushed a commit
to Viren6/Stockfish
that referenced
this pull request
Feb 12, 2024
Assorted cleanups closes official-stockfish#5046 No functional change Co-Authored-By: Shahin M. Shahin <41402573+peregrineshahin@users.noreply.github.com> Co-Authored-By: cj5716 <125858804+cj5716@users.noreply.github.com>
Viren6
pushed a commit
to Viren6/Stockfish
that referenced
this pull request
Feb 12, 2024
Assorted cleanups closes official-stockfish#5046 No functional change Co-Authored-By: Shahin M. Shahin <41402573+peregrineshahin@users.noreply.github.com> Co-Authored-By: cj5716 <125858804+cj5716@users.noreply.github.com>
TierynnB
pushed a commit
to TierynnB/Stockfish
that referenced
this pull request
Feb 14, 2024
Assorted cleanups closes official-stockfish#5046 No functional change Co-Authored-By: Shahin M. Shahin <41402573+peregrineshahin@users.noreply.github.com> Co-Authored-By: cj5716 <125858804+cj5716@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted cleanups.. feel free to comment with other small changes or discussion of larger cleanups.
I.e. I find our (history) stat updates to be quite deeply buried in search, though I'm not sure how possible cleanups would look like (this would be a way master...Disservin:Stockfish:refactor-history).