Refactor Futility Margin Formula

[FauziAkram]

In the current implementation, the formula involves several consecutive multiplications and divisors. Making it challenging to understand the order of operations.

Refactor Futility Margin Formula, to make it easier to understand.
Since using ternary operator, the logic, and order of operations become more apparent.
Removed the parentheses and moved the improving multiply before the divide for easier-to-read operator precedence (Thanks to @mstembera for this solution idea).

Non Functional

[Disservin]

Idk, I find using the current implementation cleaner.
Also generates slightly different code for gcc https://godbolt.org/z/cYabGn7K3

[FauziAkram]

What if instead of ternary, we add at least a few parentheses, such as:
return ((futilityMult * d) - (((3 * futilityMult) / 2) * improving));

[cj5716]

I honestly don't feel any need for changes to our existing formula, however I believe the outside brackets are redundant in our current formula

[mstembera]

What do people think about ?

return futilityMult * d - 3 * futilityMult * improving / 2;

[FauziAkram]

@mstembera So basically just completely removing the parentheses?
If this is what the majority think is better, I can modify the PR to that, even though the initial intention was different.

[mstembera]

Right no parentheses and an easier to read operator precedence by moving the improving multiply before the divide. Just a suggestion though.

[FauziAkram]

@mstembera Oh yes! I didn't see the improving placement change. This is perfect also for the mentioned issue! I didn't think of this solution.
I will modify it now, thanks.

[Disservin]

I find this discussion pretty pointless tbh...

This calculation is just pure multiplication, subtraction and division.
There's nothing crazy going on and the entire scope of the related code is 2 lines... I don't see any value in changing this, given that this will likely be tweaked soon anyway again... and it would open the opportunity for multiple pr's of this kind which just move operators and parentheses around...