Fix go mate in multithreading #5087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To actually have consistency one cannot use bestValue as it can propagate the aborted scores and more importantly out of the bound scores that we do not accept in outputting (thus we use uciScore) and label them as lowerbound/upperbound . The extra checks for `.score` is needed in voting because we use .score not .uciScore this renders only the thread that can actually be picked as best to be the one printing. No functional change
|
Related niklasf/python-chess#1070 |
|
This is still bugged after thinking about it.. discussed in discord why |
|
Link to discord for completeness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To actually have consistency one cannot use bestValue as it can propagate the aborted scores and more importantly out of the bound scores that we do not accept in outputting (thus we use uciScore) and label them as lowerbound/upperbound .
The extra checks for
.scoreis needed in voting because we use .score not .uciScore this renders only the thread that can actually be picked as best to be the one printing the mate.No functional change