-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tune14f pr #5091
Tune14f pr #5091
Conversation
clang-format 17 needs to be run on this PR. (execution 8176586090 / attempt 1) |
@FauziAkram I'm asking myself now why you do this again, after we had that entire discussion about mixing patches in #5039 ? |
@Disservin Let me reform the draft of the PR in the way that you suggested on discord while discussing 5039: The razoring patch by itself does not pass: The tuning patch by itself does not pass: While the combination of them passed both tests. |
Alright thanks, next time just include them in the PR body as well. This needs a rebase now. |
@Disservin PR body updated. |
A rebase would be nice to resolve the conflicts.. |
Closing this one, and opening #5097 rebased on the current master. |
The original idea started from @TarasVuk with his patch: https://tests.stockfishchess.org/tests/view/6516b3a8b3e74811c8af4203
And the tune was done on top of it: https://tests.stockfishchess.org/tests/view/65db923b90f639b028a53875
and: https://tests.stockfishchess.org/tests/view/65db923390f639b028a53873
The razoring patch by itself does not pass:
https://tests.stockfishchess.org/tests/view/65e9da8b0ec64f0526c3ff71
The tuning patch by itself does not pass:
https://tests.stockfishchess.org/tests/view/65e74d230ec64f0526c3d5c5
While the combination of them passed both tests.
Passed STC:
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 50496 W: 13211 L: 12868 D: 24417
Ptnml(0-2): 208, 5931, 12627, 6274, 208
https://tests.stockfishchess.org/tests/view/65e656dbb6345c1b93486281
Passed LTC:
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 78552 W: 20101 L: 19692 D: 38759
Ptnml(0-2): 45, 8690, 21395, 9103, 43
https://tests.stockfishchess.org/tests/view/65e74d140ec64f0526c3d5c3