Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune14f pr #5091

Closed
wants to merge 3 commits into from
Closed

Conversation

FauziAkram
Copy link
Contributor

@FauziAkram FauziAkram commented Mar 6, 2024

The original idea started from @TarasVuk with his patch: https://tests.stockfishchess.org/tests/view/6516b3a8b3e74811c8af4203
And the tune was done on top of it: https://tests.stockfishchess.org/tests/view/65db923b90f639b028a53875
and: https://tests.stockfishchess.org/tests/view/65db923390f639b028a53873

The razoring patch by itself does not pass:
https://tests.stockfishchess.org/tests/view/65e9da8b0ec64f0526c3ff71

The tuning patch by itself does not pass:
https://tests.stockfishchess.org/tests/view/65e74d230ec64f0526c3d5c5

While the combination of them passed both tests.

Passed STC:
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 50496 W: 13211 L: 12868 D: 24417
Ptnml(0-2): 208, 5931, 12627, 6274, 208
https://tests.stockfishchess.org/tests/view/65e656dbb6345c1b93486281

Passed LTC:
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 78552 W: 20101 L: 19692 D: 38759
Ptnml(0-2): 45, 8690, 21395, 9103, 43
https://tests.stockfishchess.org/tests/view/65e74d140ec64f0526c3d5c3

Copy link

github-actions bot commented Mar 6, 2024

clang-format 17 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/mantic/clang-format-17.

(execution 8176586090 / attempt 1)

@Disservin
Copy link
Member

@FauziAkram I'm asking myself now why you do this again, after we had that entire discussion about mixing patches in #5039 ?

@FauziAkram
Copy link
Contributor Author

FauziAkram commented Mar 8, 2024

@Disservin Let me reform the draft of the PR in the way that you suggested on discord while discussing 5039:

The razoring patch by itself does not pass:
https://tests.stockfishchess.org/tests/view/65e9da8b0ec64f0526c3ff71

The tuning patch by itself does not pass:
https://tests.stockfishchess.org/tests/view/65e74d230ec64f0526c3d5c5

While the combination of them passed both tests.
https://tests.stockfishchess.org/tests/view/65e656dbb6345c1b93486281
https://tests.stockfishchess.org/tests/view/65e74d140ec64f0526c3d5c3

@Disservin
Copy link
Member

Alright thanks, next time just include them in the PR body as well. This needs a rebase now.

@FauziAkram
Copy link
Contributor Author

@Disservin PR body updated.
Is anything else required from my part?

@Disservin
Copy link
Member

A rebase would be nice to resolve the conflicts..

@FauziAkram FauziAkram mentioned this pull request Mar 8, 2024
@FauziAkram
Copy link
Contributor Author

Closing this one, and opening #5097 rebased on the current master.

@FauziAkram FauziAkram closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants