Combine remove and add in update_accumulator_refresh_cache(). #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put remove before add processing as in other parts of the code. This is and was tested on top of PR5194. No functional change bench: 1836777
|
clang-format 17 needs to be run on this PR. (execution 8866163513 / attempt 1) |
|
I wonder if we can do something similar in update_accumulator_incremental |
|
I see, thanks |
|
IMO the ideal thing would be two have 1 PR with 2 commits. Which then can be merged without squashing. |
|
@Disservin Ok I committed this on top of #5194 w/o squashing. Let me know if you need anything else. |
|
Thanks. Then I'll close this one since your other pr will be merged then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STC https://tests.stockfishchess.org/tests/view/662d96dc6115ff6764c7f4ca
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 364032 W: 94421 L: 93624 D: 175987
Ptnml(0-2): 1261, 41983, 94811, 42620, 1341
Combine remove and add in update_accumulator_refresh_cache().
Move remove before add to match other parts of the code.
This includes and was tested on top of PR5194.
No functional change
bench: 1836777
Please let me know if I should close #5194 or something else to make it easier to commit on your end.