Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

man/fi_peer, prov/shm,efa: update peer context usage and providers using old usage #10377

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

man/fi_peer, prov/shm,efa: update peer context usage and providers using old usage #10377

wants to merge 3 commits into from
+157 −82

Commits on Oct 4, 2024

  1. man/fi_peer: update peer fid initialization language 

    Add clarification in the man page indicating that the owner is
responsible for creating unique fi_peer_*_contexts for each peer
and that the peers are only allowed to set the peer ops of that
context.

Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
    @aingerson
    aingerson committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    dfda69d View commit details
    Browse the repository at this point in the history

  2. prov/shm: use owner-allocated srx 

    The peer API has been updated to specify that the owner must allocate
the peer's fid_peer_srx. The shm implementation was allocating its
own internal fid_peer_srx.
This updates the shm implementation to assume it has a unique
fid_peer_srx and updates the imported fid_peer_srx peer_ops, saving
a pointer to the fid_peer_srx instead of the internal fid_ep which
required a wrapper function to get back to the fid_peer_srx

It also returns an internal fid_ep for the created srx which is used
to close the srx by the owner. Even though shm doesn't need anything
attached to the internal fid_ep, it is there for consistency and to
track the domain reference counting for errors.

This patch also moves the srx specific functions into smr_domain
where they belong

Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
    @aingerson
    aingerson committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f9a2bee View commit details
    Browse the repository at this point in the history

  3. prov/efa: update efa shm implementation to allocate fi_peer_srx_context 

    The previous definition of the peer API didn't specify who allocated the
second peer structure (the one referenced by the peer). The shm implementation
was choosing to duplicate the imported srx and set it internally. The new
definition specifies that the owner handle the duplication of the peer resource
which is then imported into the peer to just set. Shm has been updated accordingly
but efa needs to be updated to create a second peer_srx and set the fields to the
original one for the peer to reference the owner_ops correctly.

This also adds a missing fi_close for the shm srx resource

Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
    @aingerson
    aingerson committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    76855a9 View commit details
    Browse the repository at this point in the history