prov/efa, fabtests/efa: Only test inter_min_read_write_size for for emulated write path #10411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
force-pushed
the
inter_min_read_write_size
branch
from
ba86026
to
230ffbc
Compare
jiaxiyan
reviewed
Sep 24, 2024
shijin-aws
force-pushed
the
inter_min_read_write_size
branch
2 times, most recently
from
02c8f98
to
54622cb
Compare
|
AWS CI failure is real Need to fix |
shijin-aws
force-pushed
the
inter_min_read_write_size
branch
2 times, most recently
from
9817513
to
d84773f
Compare
wenduwan
reviewed
Sep 25, 2024
| if HAVE_EFADV | ||
| prov_efa_src_fi_efa_rdma_checker_SOURCES = \ | ||
| prov/efa/src/efa_rdma_checker.c | ||
| prov_efa_src_fi_efa_rdma_checker_LDADD = libfabtests.la |
There was a problem hiding this comment.
It's dubious to me whether LDADD is needed.
Reading https://www.gnu.org/software/automake/manual/html_node/Linking.html I think we can do prov_efa_src_fi_efa_rdma_checker_LDFLAGS = -lefa and get rid of configure.m4
There was a problem hiding this comment.
Good call out, It works for me. I added LDFLAGS and dropped 6901162.
This code checks whether efa device support rdma read or write capability. Signed-off-by: Shi Jin <sjina@amazon.com>
The env inter_min_read_write_size only applies to emulated write path. If the efa device supports RDMA write, device RDMA write will always be used. Signed-off-by: Shi Jin <sjina@amazon.com>
…rite is on FI_EFA_INTER_MIN_READ_WRITE_SIZE is only applied to emulated write protocols. When efa device supports rdma write, rdma write should always be used. Signed-off-by: Shi Jin <sjina@amazon.com>
shijin-aws
force-pushed
the
inter_min_read_write_size
branch
from
d84773f
to
04a765c
Compare
wenduwan
approved these changes
Sep 25, 2024
|
@shijin-aws While I was reviewing that one the power went out. Good to see it has been dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FI_EFA_INTER_MIN_READ_WRITE_SIZE is only applied to emulated write protocols. When efa device support rdma write,
rdma write will be always used.
This PR introduces a efa_rdma_checker.c code to check efa device's rdma read/write capability on a given platform, and
skip inter_min_read_write_size test in fabtests if the device support rdma-write.