prov/efa: Make NACK protocol fall back to DC longCTS when DC is requested #10412
+39
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot:aws:retest ... confirming AWS CI is still working well. |
shijin-aws
approved these changes
Sep 25, 2024
|
It will be better if you could also test https://github.com/ofiwg/libfabric/blob/main/fabtests/prov/efa/src/efa_exhaust_mr_reg_rdm_pingpong.c with FI_DELIVERY_COMPLETE in pytest. Currently it's only transmit_complete: https://github.com/ofiwg/libfabric/blob/main/fabtests/pytest/efa/test_rdm.py#L19-L21 |
…sted When application requests FI_DELIVERY_COMPLETE, it should fallback to the DC version of LONG CTS RTMs, as the default LongCTS is not DC. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com>
|
AWS CI failure is unrelated |
|
Can you backport to v1.22.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When application requests FI_DELIVERY_COMPLETE, it should fallback to the DC version of LONG CTS RTMs, as the default LongCTS is not DC.