Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): check enum value type before generating #1322

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Oct 5, 2024

No description provided.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 28 lines in your changes missing coverage. Please review.

Project coverage is 72.74%. Comparing base (34afe31) to head (e2dc75e).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
gen/schema_gen_primitive.go 41.86% 23 Missing and 2 partials ⚠️
gen/schema_gen.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1322      +/-   ##
==========================================
- Coverage   73.92%   72.74%   -1.18%     
==========================================
  Files         189      190       +1     
  Lines       12855    13096     +241     
==========================================
+ Hits         9503     9527      +24     
- Misses       2804     3017     +213     
- Partials      548      552       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado ernado merged commit a4498a8 into ogen-go:main Oct 7, 2024
14 checks passed
@tdakkota tdakkota deleted the fix/validate-enum-values branch October 8, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants