improved test cases

ohcnetwork · Nov 10, 2024 · 26c4c6a · 26c4c6a
1 parent 99e69c2
commit 26c4c6a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/care/facility/api/viewsets/patient.py b/care/facility/api/viewsets/patient.py
@@ -118,7 +118,9 @@ class PatientFilterSet(filters.FilterSet):
         field_name="name", lookup_expr="icontains", max_length=200
     )
     patient_no = filters.CharFilter(
-        field_name=f"{last_consultation_field}__patient_no", lookup_expr="iexact"
+        field_name=f"{last_consultation_field}__patient_no",
+        lookup_expr="iexact",
+        max_length=100,
     )
     gender = filters.ChoiceFilter(field_name="gender", choices=GENDER_CHOICES)
     age = filters.NumberFilter(field_name="age", validators=[MinValueValidator(0)])

diff --git a/care/facility/tests/test_patient_api.py b/care/facility/tests/test_patient_api.py
@@ -835,6 +835,17 @@ def test_filter_by_invalid_params(self):
             res.json()["state_name"],
         )
 
+        # invalid patient no value > 100
+        invalid_patient_no_param = "A" * 101
+        res = self.client.get(
+            self.get_base_url() + f"?patient_no={invalid_patient_no_param}"
+        )
+        self.assertEqual(res.status_code, status.HTTP_400_BAD_REQUEST)
+        self.assertIn(
+            "Ensure this value has at most 100 characters (it has 101).",
+            res.json()["patient_no"],
+        )
+
     def test_invalid_phone_params(self):
         self.client.force_authenticate(user=self.user)