feat: Added validation for max dosage and corresponding test cases #2383

care/facility/api/serializers/prescription.py

@@ -1,3 +1,5 @@
+import contextlib
+
 from django.shortcuts import get_object_or_404
 from django.utils import timezone
 from rest_framework import serializers
@@ -127,6 +129,35 @@ def validate(self, attrs):
                 {"base_dosage": "Base dosage is required."}
             )
 
+        base_dosage = attrs.get("base_dosage")
+        max_dosage = attrs.get("max_dosage")
+
+        if max_dosage:
+            if not base_dosage:
+                raise serializers.ValidationError(
+                    {"max_dosage": "Max dosage cannot be set without base dosage."}
+                )
+            try:
+                base_dosage_value = float(base_dosage.split(" ", maxsplit=1)[0])
+                max_dosage_value = float(max_dosage.split(" ", maxsplit=1)[0])
+                base_unit = base_dosage.split(" ", maxsplit=1)[1]
+                max_unit = max_dosage.split(" ", maxsplit=1)[1]
+
+                if base_unit != max_unit:
+                    raise serializers.ValidationError(
+                        {"max_dosage": f"Max dosage units ({max_unit}) must match base dosage units ({base_unit})."}
+                    )
+
+                if max_dosage_value < base_dosage_value:
+                    raise serializers.ValidationError(
+                        {
+                            "max_dosage": "Max dosage in 24 hours should be greater than or equal to base dosage."
+                        }
+                    )
+            except (ValueError, IndexError) as e:
+                raise serializers.ValidationError(
+                    {"max_dosage": "Invalid dosage format. Expected format: 'number unit' (e.g., '500 mg')"}
+                ) from e
         if attrs.get("dosage_type") == PrescriptionDosageType.PRN:
             if not attrs.get("indicator"):
                 raise serializers.ValidationError(

care/facility/tests/test_prescriptions_api.py

@@ -285,3 +285,32 @@ def test_medicine_filter_for_prescription(self):
             self.assertEqual(
                 prescription["medicine_object"]["name"], self.medicine.name
             )
+
+    def test_max_dosage_greater_than_base_dosage(self):
+        data = self.prescription_data(base_dosage="500 mg", max_dosage="1000 mg")
+        response = self.client.post(
+            f"/api/v1/consultation/{self.consultation.external_id}/prescriptions/",
+            data,
+        )
+        self.assertEqual(response.status_code, status.HTTP_201_CREATED)
+
+    def test_max_dosage_equal_to_base_dosage(self):
+        data = self.prescription_data(base_dosage="500 mg", max_dosage="500 mg")
+        response = self.client.post(
+            f"/api/v1/consultation/{self.consultation.external_id}/prescriptions/",
+            data,
+        )
+        self.assertEqual(response.status_code, status.HTTP_201_CREATED)
+
+    def test_max_dosage_less_than_base_dosage(self):
+        data = self.prescription_data(base_dosage="500 mg", max_dosage="400 mg")
+        response = self.client.post(
+            f"/api/v1/consultation/{self.consultation.external_id}/prescriptions/",
+            data,
+        )
+        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+        self.assertIn("max_dosage", response.data)
+        self.assertEqual(
+            response.data["max_dosage"][0],
+            "Max dosage in 24 hours should be greater than or equal to base dosage.",
+        )