Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Material UI components in src/Components/Resource/ResourceDetailsUpdate.tsx: #4994

Closed
3 tasks
Tracked by #5006
rithviknishad opened this issue Feb 28, 2023 · 12 comments · Fixed by #5647
Closed
3 tasks
Tracked by #5006
Assignees
Labels
good first issue Good for newcomers

Comments

@rithviknishad
Copy link
Member

23: import { CircularProgress } from "@material-ui/core";\n32: } from "@material-ui/core";

Tasks

Ensure all the below tasks are accomplished if applicable to the file being modified in the PR.

For more information see the epic issue that tracks this issue.

@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
@rithviknishad rithviknishad reopened this May 31, 2023
@MayaSatishRao
Copy link
Contributor

@rithviknishad can I do one of the tasks mentioned and create a pr? If so, can you assign this issue to me?

@rithviknishad
Copy link
Member Author

u r expected to do all that are applicable.

@MayaSatishRao
Copy link
Contributor

There are many components that are imported from Material UI like Circular Progress, Radio Group in the file. So we need to implement them using Typescript and Tailwind CSS right?

@rithviknishad
Copy link
Member Author

read the EPIC #5006
all components are already built.

@MayaSatishRao
Copy link
Contributor

@rithviknishad In ResourceDetailsUpdate.tsx file Radio, RadioGroup, FormControlLabel, CardContent, Box are also imported. But I could not find these components.

@rithviknishad
Copy link
Member Author

You won't have exact word to word component replacement.

Checkout how RadioFormField is used in other places.

You don't need RadioGroup when using that. Same for box and card content, just use divs.

@rithviknishad
Copy link
Member Author

All Legacy components should also be replaced with it's equivalent FormField components

@MayaSatishRao
Copy link
Contributor

@rithviknishad ok, can you assign this issue to me?

@rithviknishad
Copy link
Member Author

@MayaSatishRao any updates on this?

@MayaSatishRao
Copy link
Contributor

@rithviknishad I am working on this. Been a little busy working on the proposal. I will finish it within 2 days

@rithviknishad
Copy link
Member Author

@MayaSatishRao any updates?

@MayaSatishRao
Copy link
Contributor

I will make a pr by eod @rithviknishad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants