Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind src/Components/Facility/Investigations/Reports/* #5716

Merged
merged 7 commits into from
Jun 30, 2023

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Jun 17, 2023

WHAT

🤖 Generated by Copilot at 5c7faea

Refactored the investigations reports page and components to use custom form fields and native HTML elements with tailwind CSS. Added a select all feature and a loading indicator to the AutocompleteMultiSelect component. Improved the styling and layout of the MultiSelectMenuV2 component.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 5c7faea

  • Replace Material UI components with native elements and tailwind CSS classes in ReportTable.tsx and index.tsx to improve performance and consistency (link, link, link, link, link, link, link, link, link, link)
  • Add isLoading and selectAll props to AutocompleteMultiSelectFormField component and implement logic for selecting and deselecting all options in AutocompleteMultiselect.tsx and index.tsx to enhance functionality and user experience (link, link, link, link, link, link)
  • Reorder imports and remove unused imports and variables in ReportTable.tsx, index.tsx, AutocompleteMultiselect.tsx, and MultiSelectMenuV2.tsx to optimize code quality and readability (link, link, link, link, link, link)
  • Modify handleGroupSelect function in index.tsx to accept a FieldChangeEvent object and access the value property instead of the target.value property to fix a type error and align with the AutocompleteMultiSelectFormField component (link)
  • Remove handleSelectAllClick function in index.tsx as it was no longer needed after replacing the LegacyMultiSelectField component with the AutocompleteMultiSelectFormField component (link)
  • Modify dropdownOptionClassNames function in MultiSelectMenuV2.tsx to add the w-full class to the option elements to ensure consistent width (link)

@khavinshankar khavinshankar requested a review from a team June 17, 2023 06:33
@khavinshankar khavinshankar requested a review from a team as a code owner June 17, 2023 06:33
@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 6:27pm

@netlify
Copy link

netlify bot commented Jun 17, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ae85d7e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649b29ac0918fc0008fdf11e
😎 Deploy Preview https://deploy-preview-5716--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 17, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 21, 2023
@github-actions
Copy link

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jun 21, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Jun 27, 2023
@gigincg gigincg merged commit b1db91e into develop Jun 30, 2023
24 checks passed
@github-actions
Copy link

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the tailwind-reports branch June 30, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants