Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to None for daily round fields #8377

Open
2 tasks
Tracked by #7234
sainak opened this issue Aug 20, 2024 · 5 comments
Open
2 tasks
Tracked by #7234

Default to None for daily round fields #8377

sainak opened this issue Aug 20, 2024 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@sainak
Copy link
Member

sainak commented Aug 20, 2024

Some fields are being saved as 0 in daily rounds
Tasks:

  • change the defaults to None
  • update any dependent calculations that might expect an integer
@sainak sainak mentioned this issue Aug 20, 2024
4 tasks
@sainak sainak added the good first issue Good for newcomers label Aug 20, 2024
@Nithin9585
Copy link
Contributor

Hi @sainak, I'm interested in working on this issue. Could you please assign it to me?

@sainak sainak added good first issue Good for newcomers and removed good first issue Good for newcomers labels Aug 21, 2024
@Nithin9585
Copy link
Contributor

@sainak I'm interested in working on this issue. Could you please assign it to me?

@shivankacker
Copy link
Member

@Nithin9585 assigned this to you

@rithviknishad
Copy link
Member

@Nithin9585 unassigning due to inactivity.

@rithviknishad
Copy link
Member

Was completed in #8316
Issue needs to be re-evaluated and re-tested for confirmation for closing this, so assigning to @nihal467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Review required
Development

No branches or pull requests

5 participants