Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in label prop name for RadioFormField #8529

Closed
rithviknishad opened this issue Sep 12, 2024 · 1 comment · Fixed by #8533
Closed

Consistency in label prop name for RadioFormField #8529

rithviknishad opened this issue Sep 12, 2024 · 1 comment · Fixed by #8533
Assignees
Labels
good first issue Good for newcomers

Comments

@rithviknishad
Copy link
Member

The RadioFormField component uses optionDisplay prop to render the label. However, all other CareUI components such as SelectFormField, MultiSelectFormField, AutocompleteFormField, 'AutocompleteMultiselectFormField, etc. uses optionLabel` as the prop name to for the field label.

Hence for improving consistency, let's rename the optionDisplay to optionLabel for the RadioFormField component.

Screenshots

Usages of optionLabel (185 results)

image

Usages of optionDisplay (28 results) that needs to be replaced with optionLabel

image
@rithviknishad rithviknishad added the good first issue Good for newcomers label Sep 12, 2024
@xakep8
Copy link
Contributor

xakep8 commented Sep 12, 2024

I would like to work on this issue could you assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants