Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove facility cover image upload tooltip #8586

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Sep 21, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@sainak sainak requested a review from a team as a code owner September 21, 2024 17:29
Copy link

netlify bot commented Sep 21, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 1b80aae
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f68e2e5d4cc100091c1273
😎 Deploy Preview https://deploy-preview-8586--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Sep 21, 2024

CARE    Run #3472

Run Properties:  status check passed Passed #3472  •  git commit 1b80aaec28: Remove facility cover image upload tooltip
Project CARE
Branch Review sainak/fix/remove-cover-tooltip
Run status status check passed Passed #3472
Run duration 03m 16s
Commit git commit 1b80aaec28: Remove facility cover image upload tooltip
Committer Aakash Singh
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124
View all changes introduced in this branch ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 23, 2024
Copy link

👋 Hi, @sainak,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1b80aae
Status: ✅  Deploy successful!
Preview URL: https://648e89b6.care-fe.pages.dev
Branch Preview URL: https://sainak-fix-remove-cover-tool.care-fe.pages.dev

View logs

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 24, 2024
@nihal467
Copy link
Member

nihal467 commented Sep 24, 2024

@sainak
image

  • the tooltip still exist even after the image is fully loaded

@samholics
Copy link

Tested, now the Tooltip is removed @nihal467

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 50d4164 into develop Oct 1, 2024
26 checks passed
@khavinshankar khavinshankar deleted the sainak/fix/remove-cover-tooltip branch October 1, 2024 09:18
Copy link

github-actions bot commented Oct 1, 2024

@sainak Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Tooltip Message After Cover Image Edit
5 participants