-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made a reusable component for table in routine and nursing care procedures #8608
base: develop
Are you sure you want to change the base?
made a reusable component for table in routine and nursing care procedures #8608
Conversation
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
const SharedSectionTable: React.FC<SharedSectionTableProps> = ({ | ||
data, | ||
rows, | ||
choices = {}, | ||
translateKey, | ||
t, | ||
}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename this to be
LogUpdateAnalayseTable
since it's built for it. - use
useTranslations
instead of passing it as a prop. - i18n suffix
LOG_UPDATE_FIELD_LABEL__
is not going to change, so skip passing it as a prop.
const SharedSectionTable: React.FC<SharedSectionTableProps> = ({ | |
data, | |
rows, | |
choices = {}, | |
translateKey, | |
t, | |
}) => { | |
const LogUpdateAnalayseTable: React.FC<SharedSectionTableProps> = ({ | |
data, | |
rows, | |
choices = {}, | |
}) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this in ConsultationNursingTab
file itself. Keeping one section here and one section in a separate file isn't nice.
Changes made
fixes: #8562
@ohcnetwork/care-fe-code-reviewers
Merge Checklist