Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made a reusable component for table in routine and nursing care procedures #8608

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Sahil-Sinha-11
Copy link

@Sahil-Sinha-11 Sahil-Sinha-11 commented Sep 24, 2024

Changes made
fixes: #8562

  1. Added a reusable component.
  2. fixed width of the 2nd column onwards

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Sahil-Sinha-11 Sahil-Sinha-11 requested a review from a team as a code owner September 24, 2024 09:35
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit cd16e35
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f2949ab843c800089252c4
😎 Deploy Preview https://deploy-preview-8608--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Sep 24, 2024

image

  • add the translation to the options
  • the dates are shown as invalid under the nursing care section

image

  • as per issue, the first row should be frozen while scrolling, which is still not solved

@Sahil-Sinha-11 @rithviknishad

Comment on lines +13 to +19
const SharedSectionTable: React.FC<SharedSectionTableProps> = ({
data,
rows,
choices = {},
translateKey,
t,
}) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Rename this to be LogUpdateAnalayseTable since it's built for it.
  2. use useTranslations instead of passing it as a prop.
  3. i18n suffix LOG_UPDATE_FIELD_LABEL__ is not going to change, so skip passing it as a prop.
Suggested change
const SharedSectionTable: React.FC<SharedSectionTableProps> = ({
data,
rows,
choices = {},
translateKey,
t,
}) => {
const LogUpdateAnalayseTable: React.FC<SharedSectionTableProps> = ({
data,
rows,
choices = {},
}) => {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this in ConsultationNursingTab file itself. Keeping one section here and one section in a separate file isn't nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancements to Nursing tab UI
3 participants