Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced the UI of Location mangement Page anf fixed some minor bugs #2797

Closed
wants to merge 1 commit into from
Closed

Enhanced the UI of Location mangement Page anf fixed some minor bugs #2797

wants to merge 1 commit into from

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Jun 22, 2022 •
edited
Loading

Fixes #2779

Bugs Fixed

  • Added icons to buttons, made buttons at par with the rest buttons in CARE, improved typography, and added the "--" symbol when the description is empty
    image
  • Removed components of material UI and added tailwind components as a part of Switch to Tailwind UI from Material UI #2776

video1.mp4
  • Removed the old loader and added a new one while saving location

video2.mp4
  • Added validation in the location edit form and prevented it from saving without validation

@patelaryan7751 patelaryan7751 requested a review from a team June 22, 2022 07:18
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner June 22, 2022 07:18
@patelaryan7751
Copy link
Contributor Author

Deploy preview ready https://deploy-preview-2797--care-net.netlify.app/

shivankacker
shivankacker approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@shivankacker shivankacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@patelaryan7751 patelaryan7751 deleted the issue#2779 branch June 27, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeswibon aeswibon aeswibon approved these changes

@shivankacker shivankacker shivankacker approved these changes

Assignees
No one assigned
Labels
needs testing peer-reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ui Enhancement of Location Management Page
3 participants
@patelaryan7751 @shivankacker @aeswibon