-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Storybook + 🛠 Tailwind Patient Filters #3744
📖 Storybook + 🛠 Tailwind Patient Filters #3744
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@khavinshankar can you check this |
unable to type in the lsg body filters or any other filters |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Patient Filter LGTM @khavinshankar go through story book |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- shouldn't we remove or customize the introduction page in the storybook?
- and in storybook, can't pick a date in date range component
merging this pr, pickup the issues in a new pr
Working on this PR may require you to run
npm i --legacy-peer-deps
oryarn install
again.Post Merge Tasks
develop
branch instead of this PR branch.Proposed Changes
SelectMenu
tailwind component. #3686DateInputV2
tailwind component #3784Storybook
Write stories of components inside
src/stories
directory, ending with*.stories.tsx
or*.stories.mdx
.Example:
References
To run storybook locally:
open http://localhost:6006 in your browser
Storybook preview deployment for this branch until its merged can be viewed at: https://care-fe-storybook.vercel.app
VS Code Extensions that might be helpful when working with Storybook
.mdx
stories:Additional add-ons in Storybook
New Components
See storybook for component API documentation.
SelectMenuV2
Rebuilt to be consistent with other components' API and support for option icons.
MultiSelectMenuV2
AutoCompleteAsync
by @khavinshankar
TextFormField
andTextAreaFormField
DatePicker
andDateRangePicker
by @Ritesh-Aggarwal
Patient Filters Redesigned
As per figma design
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist