Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Storybook + 🛠 Tailwind Patient Filters #3744

Merged
merged 100 commits into from
Oct 26, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 10, 2022

⚠️ There are additional packages in this PR, for the storybook.
Working on this PR may require you to run npm i --legacy-peer-deps or yarn install again.

Post Merge Tasks

  • Update vercel deploy config to use develop branch instead of this PR branch.
  • Update README.md with the storybook staging deploy URL.

Proposed Changes

Storybook

Write stories of components inside src/stories directory, ending with *.stories.tsx or *.stories.mdx.

Example:

// Button.stories.tsx

import { ComponentStory } from "@storybook/react";
import ButtonV2 from "../Components/Common/components/ButtonV2";

export default {
  title: "Care UI / Button", // having '/' in title organizes the stories in a grouped/directory structure.
  component: ButtonV2,
};

const Template: ComponentStory<typeof ButtonV2> = (args) => (
  <ButtonV2 {...args}>Label</ButtonV2>
);

export const Button = Template.bind({});

References

To run storybook locally:

npm install --legacy-peer-deps # install new packages required
npm run storybook # launch storybook

open http://localhost:6006 in your browser

Storybook preview deployment for this branch until its merged can be viewed at: https://care-fe-storybook.vercel.app

VS Code Extensions that might be helpful when working with Storybook .mdx stories:

Additional add-ons in Storybook

New Components

See storybook for component API documentation.

SelectMenuV2

Rebuilt to be consistent with other components' API and support for option icons.
image

MultiSelectMenuV2

image
image

AutoCompleteAsync

by @khavinshankar
image

TextFormField and TextAreaFormField

image
image

DatePicker and DateRangePicker

by @Ritesh-Aggarwal
image

Patient Filters Redesigned

As per figma design

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@netlify
Copy link

netlify bot commented Oct 10, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fc3268a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6358ee810f22770008a61326
😎 Deploy Preview https://deploy-preview-3744--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@khavinshankar can you check this

@nihal467
Copy link
Member

nihal467 commented Oct 24, 2022

@rithviknishad
image

unable to type in the lsg body filters or any other filters

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 25, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 25, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 26, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 26, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 26, 2022
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Oct 26, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Oct 26, 2022

Patient Filter LGTM @khavinshankar go through story book

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rithviknishad

  • shouldn't we remove or customize the introduction page in the storybook?
  • and in storybook, can't pick a date in date range component

merging this pr, pickup the issues in a new pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Major Code Change This Tag represent PR, which will be causing major Code change in the platform needs review redesign tested
Projects
None yet
8 participants