-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwinds SampleFilters.tsx
#5630
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LGTM |
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
WHAT
🤖 Generated by Copilot at ce8b1e7
The pull request improves the filter UI for patient samples and fixes a type mismatch issue with the
sample_type
query parameter. It uses custom form field components, simplifies the state management, and changes theid
property of theSAMPLE_TYPE_CHOICES
array from a number to a string insrc/Common/constants.tsx
andsrc/Components/Patient/SampleViewAdmin.tsx
.Proposed Changes
src/Components/Patient/SampleFilters.tsx
: #4982@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at ce8b1e7
id
property of theSAMPLE_TYPE_CHOICES
array from a number to a string to match thesample_type
query parameter (link)LegacySelectField
components with theSelectFormField
components in the sample filter UI to use custom form fields with consistent styles and props (link, link)handleChange
function inSampleFilters.tsx
to use theFieldChangeEvent
type and theuseMergeState
hook (link, link)CircularProgress
,FieldLabel
,SelectFormField
components and theFieldChangeEvent
type from custom files instead of external libraries inSampleFilters.tsx
(link)sample_type
filter value inSampleFilters.tsx
(link)className
prop from theFacilitySelect
component inSampleFilters.tsx
as it was not needed (link)id
property of theSAMPLE_TYPE_CHOICES
array with thesample_type
query parameter as a string inSampleViewAdmin.tsx
to match the change in link (link)