Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds SampleDetails.tsx #5631

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Tailwinds SampleDetails.tsx #5631

merged 4 commits into from
Jun 12, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 8, 2023

WHAT

🤖 Generated by Copilot at d627a3e

Refactor SampleDetails component to use common UI elements and fix minor bugs.

Proposed Changes

image

@nihal467 the file upload on this page is tracked in a different issue #4977 as it's a generic component.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at d627a3e

  • Remove unused imports and use custom components from CAREUI or Common modules for consistency and styling (link, link, link, link, link)
  • Destructure id prop from props parameter in SampleDetails component to avoid repetition (link)
  • Rename yesornoBadge function to yesOrNoBadge to follow camelCase convention and improve readability (link, link, link, link, link)
  • Replace PageTitle component with Page component in SampleDetails component to simplify layout and include back button and options (link)
  • Replace PageTitle component with h4 element in sample test history section to avoid unnecessary back button and breadcrumbs (link)
  • Close Page component tag to match opening tag (link)

@rithviknishad rithviknishad requested a review from a team June 8, 2023 18:53
@rithviknishad rithviknishad requested a review from a team as a code owner June 8, 2023 18:53
@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2023 5:09am

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7ea5e78
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6484055c675da600088388b3
😎 Deploy Preview https://deploy-preview-5631--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 8, 2023
@github-actions github-actions bot added cypress failed pull request with cypress test failure and removed cypress failed pull request with cypress test failure labels Jun 10, 2023
@nihal467 nihal467 removed the cypress failed pull request with cypress test failure label Jun 10, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit f49ac41 into develop Jun 12, 2023
@khavinshankar khavinshankar deleted the tailwind/4981 branch June 12, 2023 12:18
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Patient/SampleDetails.tsx:
3 participants