-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailwinds SampleDetails.tsx
#5631
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LGTM |
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
WHAT
🤖 Generated by Copilot at d627a3e
Refactor
SampleDetails
component to use common UI elements and fix minor bugs.Proposed Changes
src/Components/Patient/SampleDetails.tsx
: #4981@nihal467 the file upload on this page is tracked in a different issue #4977 as it's a generic component.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at d627a3e
CAREUI
orCommon
modules for consistency and styling (link, link, link, link, link)id
prop fromprops
parameter inSampleDetails
component to avoid repetition (link)yesornoBadge
function toyesOrNoBadge
to follow camelCase convention and improve readability (link, link, link, link, link)PageTitle
component withPage
component inSampleDetails
component to simplify layout and include back button and options (link)PageTitle
component withh4
element in sample test history section to avoid unnecessary back button and breadcrumbs (link)Page
component tag to match opening tag (link)