-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to CareUI components in ResourceDetailsUpdate.tsx component #5647
Migrating to CareUI components in ResourceDetailsUpdate.tsx component #5647
Conversation
@MayaSatishRao is attempting to deploy a commit to the Coronasafe Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@rithviknishad Could u please verify if all the materialUI components are migrated? |
Also update your PR title to something meaningful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've also not migrated PageTitle component
I have made the requested changes @rithviknishad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You could have passed the classNames directly to the Form field components instead of wrapping it in a div and specifying it there. Code would have looked cleaner!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MayaSatishRao use the new UserAutocompleteFormField
by merging latest develop
@MayaSatishRao any updates on this? |
@rithviknishad I have made the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you have replaced all the MUI components?
There shouldn't be any imports of material ui |
@rithviknishad i have made the changes. I am still using FieldLabel for FacilitySelect because it does not have label prop. Other than this all other components are from CareUI |
LGTM |
WHAT
🤖 Generated by Copilot at 5855b3a
This pull request improves the user interface and experience of the consultation and resource management features, and fixes a bug in the
AutoCompleteAsync
component. It adds a function to show customized notification messages inConsultationForm.tsx
, refactorsResourceDetailsUpdate.tsx
to use the CAREUI library components, and clears the query state and disables the browser's autocomplete inAutoCompleteAsync.tsx
.Proposed Changes
src/Components/Resource/ResourceDetailsUpdate.tsx
: #4994@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers