Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds ManagePatients.tsx #5657

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Tailwinds ManagePatients.tsx #5657

merged 1 commit into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 13, 2023

WHAT

🤖 Generated by Copilot at 4903fe3

This pull request improves the manage patients page by removing unnecessary code and enhancing the user interface. It uses simpler and more consistent components for displaying the page title and tooltips, and adjusts the layout and style of the page elements.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 4903fe3

  • Replace Tooltip components with custom span elements for better accessibility and responsiveness (link, link, link)
  • Add Page component as a wrapper for PatientManager component to provide consistent layout and header (link, link)
  • Remove redundant PageTitle component (link)
  • Remove commented-out code for discharged patients card (link)

@rithviknishad rithviknishad requested a review from a team June 13, 2023 15:49
@rithviknishad rithviknishad requested a review from a team as a code owner June 13, 2023 15:49
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 3:50pm

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4903fe3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648890224b779a000840094c
😎 Deploy Preview https://deploy-preview-5657--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 72bddfb into develop Jun 21, 2023
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the tailwind/4978 branch June 21, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Patient/ManagePatients.tsx:
3 participants