Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds Update Status Dialog #5663

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Tailwinds Update Status Dialog #5663

merged 6 commits into from
Jun 28, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 13, 2023

WHAT

🤖 Generated by Copilot at e857222

Refactored the UpdateStatusDialog component to use reusable and consistent UI components from ConfirmDialogV2 and FormFields. Simplified the code by removing unused parts and updating the handleChange function.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at e857222

  • Replace the Dialog component and its children with the ConfirmDialogV2 component, which provides a consistent and reusable confirmation dialog for the user. (link, link)
  • Replace the LegacySelectField and LegacyCheckboxField components with the new SelectFormField and CheckBoxFormField components, which provide a better user interface and validation for the form inputs. (link)
  • Add the TextFormField component to display the current status as a disabled input field. (link)
  • Modify the handleChange function to accept a FieldChangeEvent object instead of a name and value pair, as this is the standard interface for the new FormFields components. (link)
  • Remove the unused imports of the Dialog components, the Cancel component, and the LegacyCheckboxField and LegacySelectField components from the UpdateStatusDialog.tsx file. (link, link, link)
  • Remove the handleEscKeyPress function, as it is no longer needed to handle the escape key press event, as the ConfirmDialogV2 component handles it internally. (link)

@rithviknishad rithviknishad requested a review from a team June 13, 2023 17:43
@rithviknishad rithviknishad requested a review from a team as a code owner June 13, 2023 17:43
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 6:08am

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f5d3574
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649bce1e4e4e2600083d8d6e
😎 Deploy Preview https://deploy-preview-5663--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 13, 2023
@rithviknishad rithviknishad added needs testing and removed changes required cypress failed pull request with cypress test failure labels Jun 19, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 19, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Jun 27, 2023
@nihal467
Copy link
Member

@rithviknishad
image

make the upload button also tailwind

@nihal467
Copy link
Member

@rithviknishad
image

unable to understand where a file is selected or not, because when i select a file, no file name is shown in the UI

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit fc5f0a7 into develop Jun 28, 2023
@khavinshankar khavinshankar deleted the tailwinds/4988 branch June 28, 2023 06:44
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Patient/UpdateStatusDialog.tsx:
3 participants