Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds ManageUsers.tsx #5664

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Tailwinds ManageUsers.tsx #5664

merged 4 commits into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 13, 2023

WHAT

🤖 Generated by Copilot at 794f431

Refactored ManageUsers.tsx to use common UI components.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 794f431

  • Replace Button and CircularProgress components from @material-ui/core with custom components from ../Common/components for consistent styling and functionality (link, link)
  • Wrap ManageUsers component inside Page component from ../Common/components/Page.js to include title, back button, and breadcrumbs as props and provide consistent layout for the pages (link, link, link)
  • Remove PageTitle component as it is redundant with Page component (link)

@rithviknishad rithviknishad requested a review from a team June 13, 2023 18:01
@rithviknishad rithviknishad requested a review from a team as a code owner June 13, 2023 18:01
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2023 9:53am

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7b39c58
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64902574847d0800082a39b6
😎 Deploy Preview https://deploy-preview-5664--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 13, 2023
@rithviknishad rithviknishad added needs testing and removed cypress failed pull request with cypress test failure labels Jun 17, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 17, 2023
@rithviknishad rithviknishad added Cypress Test Pending The Cypress test are to be verified and removed needs testing labels Jun 17, 2023
@rithviknishad rithviknishad added needs testing and removed Cypress Test Pending The Cypress test are to be verified cypress failed pull request with cypress test failure labels Jun 19, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 19, 2023
@rithviknishad rithviknishad removed the cypress failed pull request with cypress test failure label Jun 19, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit a4fd3ef into develop Jun 21, 2023
@khavinshankar khavinshankar deleted the tailwind/5002 branch June 21, 2023 06:34
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Users/ManageUsers.tsx:
3 participants