Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailwinds ResourceBoard.tsx #5666

Closed
wants to merge 2 commits into from
Closed

Tailwinds ResourceBoard.tsx #5666

wants to merge 2 commits into from

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 13, 2023 •
edited
Loading

WHAT

🤖 Generated by Copilot at 0356346

Refactored the resource board component to use a custom loading indicator. Improved the user feedback for the resource download feature.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 0356346

  • Replace the material-ui CircularProgress component with the custom one in ResourceBoard.tsx (link, link, link)
  • Remove the unused className prop from the custom CircularProgress component (link)

@rithviknishad rithviknishad requested a review from a team June 13, 2023 18:34
@rithviknishad rithviknishad requested a review from a team as a code owner June 13, 2023 18:34
@vercel
Copy link

vercel bot commented Jun 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2023 9:24am

@netlify
Copy link

netlify bot commented Jun 13, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 462d1c9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648d7b81b36d210008e46107
😎 Deploy Preview https://deploy-preview-5666--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 16, 2023
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Jun 17, 2023
@github-actions github-actions bot added cypress failed pull request with cypress test failure cypress passed and removed cypress passed cypress failed pull request with cypress test failure labels Jun 17, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar
Copy link
Member

no changes, merged in diff fork

@rithviknishad
Copy link
Member Author

Oh damn, didn't notice that when merged develop into this 😅

@rithviknishad rithviknishad deleted the tailwind/4991 branch July 26, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Resource/ResourceBoard.tsx:
3 participants
@rithviknishad @nihal467 @khavinshankar