Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced material ui in FacilityCreate.tsx #5719

Merged
merged 7 commits into from
Jun 30, 2023

Conversation

print-Sathvik
Copy link
Contributor

@print-Sathvik print-Sathvik commented Jun 18, 2023

WHAT

🤖 Generated by Copilot at b549c21

Improved the user interface and functionality of the GLocationPicker component by adding a Popover map panel and fixing a close icon bug.

Proposed Changes

  • Fixes Replace Material UI components in src/Components/Facility/FacilityCreate.tsx: #4952
  • Replaced Material UI in FacilityCreate.tsx
  • Wrapped close button of GLocationPicker with Popover.Button after replacing material UI's Popover component with headlessui's Popover component as that's the only way to close the Popover according to the docs.
  • GLocationPicker component does not load the map in mobile view / at lower width and the search box and close button occupy the entire space as in the below screenshot. Fixed that issue too.

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at b549c21

  • Import the Popover component from @headlessui/react library to create a dismissible floating panel for the map (link)
  • Wrap the close icon for the map in a Popover.Button component to control the visibility of the Popover component and fix a bug where the map would not close when clicking the icon (link)

@print-Sathvik print-Sathvik requested a review from a team June 18, 2023 21:31
@print-Sathvik print-Sathvik requested a review from a team as a code owner June 18, 2023 21:31
@vercel
Copy link

vercel bot commented Jun 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 5:41am

@netlify
Copy link

netlify bot commented Jun 18, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 261bb21
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649e86205babac0008cd4da3
😎 Deploy Preview https://deploy-preview-5719--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest all LGTM

src/Components/Facility/FacilityCreate.tsx Outdated Show resolved Hide resolved
src/Components/Facility/FacilityCreate.tsx Outdated Show resolved Hide resolved
src/Components/Facility/FacilityCreate.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 22, 2023
@github-actions
Copy link

👋 Hi, @print-Sathvik,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jun 22, 2023
@nihal467
Copy link
Member

@print-Sathvik @rithviknishad
image

the map is not properly aligned, make it appear near the icon

@print-Sathvik
Copy link
Contributor Author

Can someone else take this up. When I fixed this some other issues starte.

@print-Sathvik @rithviknishad image

the map is not properly aligned, make it appear near the icon

@khavinshankar
Copy link
Member

Fixed the positioning of location picker

image

cc: @nihal467 @print-Sathvik

@nihal467 nihal467 added cypress failed pull request with cypress test failure and removed cypress passed labels Jun 30, 2023
@nihal467
Copy link
Member

@print-Sathvik @khavinshankar the cypress is failing, which is related to this PR, fix it

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit dcce8f8 into ohcnetwork:develop Jun 30, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Facility/FacilityCreate.tsx:
4 participants