-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MaterialUI in FileUpload.tsx #5720
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@print-Sathvik you can do it along with this PR and link that issue too. |
Ok @rithviknishad , that's done. I noticed one more issue. Those buttons are overflowing when width is decreased. I will fix that and create a commit evening after going home |
@nihal467 that space is for the error for that field. In existing staging when error comes, layout shift happens. But layout shift is not good, hence new components automatically keeps the spacing consistent to prevent layout shifts. |
@print-Sathvik maybe we can add some spacing above the field so that it looks good in all views |
the above image is a mockup I made, can we have something similar? |
Ok @nihal467 , will do that tonight |
LGTM |
WHAT
🤖 Generated by Copilot at 73b140d
This pull request refactors the FileUpload component to use custom components and the Page component, and adds a custom background color option to the DialogModal component. These changes aim to improve the performance, design, and maintainability of the application.
Proposed Changes
src/Components/Patient/FileUpload.tsx
: #4977Edit 29/06/2023:
.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at 73b140d
bg-
class name as a prop (link)