Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header on Patient list page #5736

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Fix header on Patient list page #5736

merged 2 commits into from
Jun 21, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 21, 2023

WHAT

🤖 Generated by Copilot at 5e01a7f

This pull request improves the Page component and its usage in the PatientManager component. It fixes a potential bug with passing undefined as a class name in Page.tsx, and it refactors the options rendering in ManagePatients.tsx to use the Page component's prop instead of its children. These changes enhance the code quality and consistency of the project.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 5e01a7f

  • Add fallback value for className prop in Page component to prevent undefined class name (link)
  • Refactor PatientManager component to use options prop of Page component instead of rendering options inside Page children (link)

@Ashesh3 Ashesh3 requested a review from a team June 21, 2023 14:22
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 21, 2023 14:22
@Ashesh3 Ashesh3 requested a review from gigincg June 21, 2023 14:22
@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 7:44pm

@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8ce8361
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649352f0dcf5ea0008690ddd
😎 Deploy Preview https://deploy-preview-5736--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 21, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 86ff9e4 into develop Jun 21, 2023
23 of 24 checks passed
@khavinshankar khavinshankar deleted the fix-patient-header branch June 21, 2023 23:48
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants