Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Use stock adds to stock quantity instead of subracting from quantity #5760

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Jun 22, 2023

WHAT

🤖 Generated by Copilot at 2f0c82f

Fixed a bug in the AddInventoryForm component that could cause incorrect inventory items to be added to a facility. Changed the optionValue prop of the SelectField component to use the id property of the inventory object instead of the name property.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 2f0c82f

  • Change the optionValue prop of the SelectField component to use the id property of the inventory object instead of the name property (link). This fixes a bug where the wrong inventory item could be selected and sent to the backend when the form is submitted, since the name property may not be unique for different inventory items.

@GokulramGHV GokulramGHV requested a review from a team June 22, 2023 13:35
@GokulramGHV GokulramGHV requested a review from a team as a code owner June 22, 2023 13:35
@GokulramGHV GokulramGHV requested a review from gigincg June 22, 2023 13:35
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 5:40pm

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 89b1b4e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649b1ede5c005f0008393f9b
😎 Deploy Preview https://deploy-preview-5760--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 1365104 into ohcnetwork:develop Jun 28, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use stock function is malfunctioning in facility inventory
3 participants