Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing imports in Form component #5761

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 22, 2023

WHAT

🤖 Generated by Copilot at f0414cc

This pull request enhances the form component by using useMemo and FormState for better type checking and caching, and by allowing forms without validation.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at f0414cc

  • Import useMemo hook to memoize form context value (link)
  • Import FormState type to annotate form reducer state and draft handler parameter (link, link)
  • Make validate function optional to avoid errors or unnecessary validations (link)

@Ashesh3 Ashesh3 added needs testing P1 breaking issue or vital feature labels Jun 22, 2023
@Ashesh3 Ashesh3 requested a review from a team June 22, 2023 14:11
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 22, 2023 14:11
@Ashesh3 Ashesh3 requested a review from bodhish June 22, 2023 14:11
@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 2:11pm

@netlify
Copy link

netlify bot commented Jun 22, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f0414cc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649456892bb18800089af5f7
😎 Deploy Preview https://deploy-preview-5761--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 22, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit de4996d into develop Jun 23, 2023
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@sainak sainak deleted the fix-form-import branch February 21, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants