Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons in Live feed controller #5777

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Fix icons in Live feed controller #5777

merged 1 commit into from
Jun 24, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 24, 2023

WHAT

🤖 Generated by Copilot at fbd6f8f

Replaced font-awesome icons with custom CareIcon component in LiveFeed.tsx. This improves the appearance and consistency of the live feed options.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at fbd6f8f

  • Replace font-awesome icons with custom CareIcon component for live feed options (link)
  • Pass the option name as a prop to the CareIcon component in the renderOption function in src/Components/Facility/Consultations/LiveFeed.tsx (link)

@Ashesh3 Ashesh3 requested a review from a team June 24, 2023 11:18
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 24, 2023 11:18
@Ashesh3 Ashesh3 requested a review from vigneshhari June 24, 2023 11:18
@vercel
Copy link

vercel bot commented Jun 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2023 11:19am

@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fbd6f8f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6496d104a23c7f000857514c
😎 Deploy Preview https://deploy-preview-5777--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit ca5b767 into develop Jun 24, 2023
32 of 33 checks passed
@khavinshankar khavinshankar deleted the fix-icons branch June 24, 2023 11:33
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants