Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor ui fixes in shifting and consultation #5784

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 26, 2023

WHAT

🤖 Generated by Copilot at 77f8c19

This pull request improves the UI and consistency of the CopyToClipboard component and the shifting module translations. It adds a new prop to the CopyToClipboard component to control the tooltip position and removes a period from the ambulance_number value in src/Locale/en/Shifting.json.

Proposed Changes

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 77f8c19

  • Add tooltipPosition prop to CopyToClipboard components in ConsultationCard and SampleTestCard components to align the tooltip to the left of the copy icon (link, link, link, link)
  • Remove period from the value of ambulance_number key in Shifting.json file to make it consistent with other values (link)

@Ashesh3 Ashesh3 requested a review from a team June 26, 2023 07:44
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 26, 2023 07:44
@Ashesh3 Ashesh3 requested a review from bodhish June 26, 2023 07:44
@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 3:34am

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9df7f72
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/649a5889a502a10008bc2fd9
😎 Deploy Preview https://deploy-preview-5784--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 26, 2023
@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Jun 27, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 7686db2 into develop Jun 28, 2023
@khavinshankar khavinshankar deleted the issue-5766 branch June 28, 2023 05:13
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor enhancement in shift form and patient detail page
3 participants