Cypress Test | Facility Creation & Updation | POM Approach #5787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
cypress failed
github-actions
bot
added
cypress passed
and removed
cypress failed
khavinshankar
approved these changes
Jun 27, 2023
|
@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 2832329
Refactored the facility and patient tests in
cypress/e2eto use a page object model for the facility form. Added a new modulecypress/pageobject/Facility/FacilityCreation.tsthat defines theFacilityPageclass for interacting with the form. Fixed a bug in generating random phone numbers.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 2832329
FacilityPageclass fromcypress/pageobject/Facility/FacilityCreation.tsand create an instance asfacilityPage(link)facilityclass andcurrent_urlvariable as they are no longer needed (link, link)facilityPagemethods to fill and select form fields, submit form, and select location on map (link)describeblock to "Facility Creation" anditblocks to "Create a new facility" and "Update the existing facility" (link, link)facilityUrlvariable to store the url of the created facility for the update test (link)FacilityPageto encapsulate facility creation and update pages (link)FacilityPageclass incypress/pageobject/Facility/FacilityCreation.tswith methods for visiting, filling, selecting, submitting, and locating (link)FacilityPageclass as the default export of the module (link)