Fixes date time initial value formatting for Log update measured at, Discharge (death date time) and Bed start date time #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM |
khavinshankar
approved these changes
Jul 27, 2023
|
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 3b6492f
The pull request updates several components in the
src/Components/Facilityandsrc/Components/Patientdirectories to usemomentlibrary for date and time formatting. This improves the code readability, consistency, and compatibility. It also fixes some UI and data issues in theDischargeModalandConsultationFormcomponents.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 3b6492f
momentlibrary to format date and time values consistently and compatibly across different browsers and time zones (link, link, link, link, link)formatDateTimefunction fromBedscomponent (link)discharge_date,death_datetime, anddeath_confirmed_doctorfields optional instead of nullable inPreDischargeFormInterfaceandIPropsinterfaces inDischargeModal.tsxto avoid sending null values to the backend API (link, link)undefinedinstead ofnullas the initial value ofdeath_confirmed_doctorfield inpreDischargeFormstate inDischargeModal.tsxfor the same reason as above (link)TextFormFieldcomponent to render the input fordeath_datetimefield inDischargeModal.tsxto ensure consistency and reusability of the UI components and to leverage the props and validations provided by the component (link)