Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort options i18n #8602

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 24, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner September 24, 2024 05:33
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit fce776b
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66f2589e8400c5000837c585
😎 Deploy Preview https://deploy-preview-8602--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Sep 24, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: fce776b
Status: ✅  Deploy successful!
Preview URL: https://4707c063.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-fix-sort-optii.care-fe.pages.dev

View logs

@rithviknishad rithviknishad self-assigned this Sep 24, 2024
Copy link

cypress bot commented Sep 24, 2024

CARE    Run #3452

Run Properties:  status check passed Passed #3452  •  git commit fce776bd1f: fix: sort options i18n
Project CARE
Branch Review rithviknishad/fix/sort-optiions-i18n
Run status status check passed Passed #3452
Run duration 03m 33s
Commit git commit fce776bd1f: fix: sort options i18n
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 121
View all changes introduced in this branch ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 5accddc into develop Sep 24, 2024
26 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/sort-optiions-i18n branch September 24, 2024 10:24
Copy link

@rithviknishad @rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translations are missing for patient sortby dropdown
3 participants