-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Breadcrumbs redirection to patient edit consultation form #8985
base: develop
Are you sure you want to change the base?
Fix: Breadcrumbs redirection to patient edit consultation form #8985
Conversation
- Added Consultation breadcrumb with URI for updating consultation - Updated backUrl for consultation update Fixes ohcnetwork#8765
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…o issues/8759/breadcrumbs-consultation
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
WalkthroughThe changes in Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)src/components/Patient/PatientConsentRecords.tsx (2)
The addition of the consultation breadcrumb with the proper URI structure fixes the navigation issue described in #8759.
The backUrl now correctly points to the consultation page, maintaining consistency with the breadcrumb navigation. Let's verify that this is the only instance of this navigation pattern that needs updating: ✅ Verification successfulBack navigation URL is correctly implemented and consistent The backUrl pattern is used consistently across the codebase:
Both implementations follow the same URL structure pattern and use template literals correctly. No inconsistencies found. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Search for similar navigation patterns that might need consistent updates
rg -g '*.tsx' -g '*.ts' "backUrl.*patient.*consultation" --no-filename
Length of output: 273 Script: #!/bin/bash
# Let's get more context around these backUrl usages to understand their purpose
rg -g '*.tsx' -g '*.ts' "backUrl.*patient.*consultation" -B 2 -A 2
Length of output: 887 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
ConfirmDialog
to dynamically display patient code status for consent records.Improvements
backUrl
.