Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Breadcrumbs redirection to patient edit consultation form #8985

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

shauryag2002
Copy link
Contributor

@shauryag2002 shauryag2002 commented Nov 2, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • New Features

    • Introduced a breadcrumb navigation entry for easier access to consultation details.
    • Updated the ConfirmDialog to dynamically display patient code status for consent records.
  • Improvements

    • Cleaned up URL structure by modifying the backUrl.
    • Enhanced upload handling logic for better interaction with existing consent records.

- Added Consultation breadcrumb with URI for updating consultation
- Updated backUrl for consultation update
Fixes ohcnetwork#8765
@shauryag2002 shauryag2002 requested a review from a team as a code owner November 2, 2024 19:04
Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit ed92f6a
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/672a591917e19c00082b62d2
😎 Deploy Preview https://deploy-preview-8985--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Copy link

coderabbitai bot commented Nov 5, 2024

Walkthrough

The changes in PatientConsentRecords.tsx introduce a breadcrumb entry for consultations, improving navigation to existing patient consultations. The backUrl has been updated to remove trailing slashes for cleaner URLs. The ConfirmDialog component's description now dynamically reflects the patient code status of consent records. Additionally, adjustments to the handleUpload function ensure it operates correctly based on existing consent records and their statuses, while maintaining the overall structure and functionality of the component.

Changes

File Change Summary
src/components/Patient/PatientConsentRecords.tsx Added breadcrumb entry for consultations; updated backUrl; modified ConfirmDialog description; adjusted handleUpload logic.

Assessment against linked issues

Objective Addressed Explanation
Breadcrumbs should redirect to the patient's existing consultation page (#8759)

Possibly related PRs

Suggested reviewers

  • rithviknishad

Poem

In the land of health, where records do flow,
A breadcrumb appears, guiding us so!
With a click, we find, the consultations we seek,
A clearer path forward, no longer oblique.
So hop with delight, for changes are here,
Navigating consent, brings us all cheer! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 764cfe3 and ed92f6a.

📒 Files selected for processing (1)
  • src/components/Patient/PatientConsentRecords.tsx (2 hunks)
🔇 Additional comments (2)
src/components/Patient/PatientConsentRecords.tsx (2)

110-113: LGTM! Breadcrumb navigation implementation looks correct.

The addition of the consultation breadcrumb with the proper URI structure fixes the navigation issue described in #8759.


123-123: LGTM! Back navigation URL is properly configured.

The backUrl now correctly points to the consultation page, maintaining consistency with the breadcrumb navigation.

Let's verify that this is the only instance of this navigation pattern that needs updating:

✅ Verification successful

Back navigation URL is correctly implemented and consistent

The backUrl pattern is used consistently across the codebase:

  • In PatientConsentRecords.tsx: navigates back to consultation
  • In DailyRoundListDetails.tsx: navigates back to daily rounds within consultation

Both implementations follow the same URL structure pattern and use template literals correctly. No inconsistencies found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for similar navigation patterns that might need consistent updates
rg -g '*.tsx' -g '*.ts' "backUrl.*patient.*consultation" --no-filename

Length of output: 273


Script:

#!/bin/bash
# Let's get more context around these backUrl usages to understand their purpose
rg -g '*.tsx' -g '*.ts' "backUrl.*patient.*consultation" -B 2 -A 2

Length of output: 887


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@nihal467
Copy link
Member

nihal467 commented Nov 6, 2024

image
image

  • the issue still exist, can you recheck the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumbs redirection to patient edit consultation form is not working as expected
3 participants