Added dynamic lock icon and strong types

[nithish1018]

Proposed Changes

• Fixes Same Lock Icon is being Displayed for both Allow Transfer and Disable Transfer #9005
• Added types and modified shift handling as in https://github.com/ohcnetwork/care_fe/blob/develop/src/components/Shifting/ShiftingBoard.tsx
• Added few minor changes

Screenshots:
Now the lock icon changes dynamically

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Enhanced type safety in the PatientHome component for improved reliability.
  • Added internationalization support with updated text labels for better user experience.

• Bug Fixes

  • Improved handling of transfer completion with type-specific parameters.

• Refactor

  • Updated state and function parameter types for clarity and maintainability.

[coderabbitai]

Walkthrough

The changes to the PatientHome component in src/components/Patient/PatientHome.tsx focus on enhancing type safety and internationalization. The import of ShiftingModel is introduced to specify types for state variables and function parameters. The rendering logic is updated to ensure type checks on the shift objects. Additionally, UI text labels are modified to utilize translation functions, improving localization support.

Changes

File	Change Summary
src/components/Patient/PatientHome.tsx	- Added import of ShiftingModel for type safety. - Updated state variable modalFor to use ShiftingModel. - Modified handleTransferComplete to accept ShiftingModel and added a guard clause. - Updated mapping of activeShiftingData.results to specify shift as ShiftingModel. - Adjusted setModalFor to pass the entire shift object. - Enhanced UI text labels for internationalization.
cypress.config.ts	- Adjusted import statements and enhanced setupNodeEvents function with a new task readFileMaybe. - Conditional invocation of cypressSplit based on CYPRESS_SPLIT_TESTS environment variable.

Assessment against linked issues

Objective	Addressed	Explanation
Same Lock Icon is being Displayed for both Allow Transfer and Disable Transfer (#9005)	❌	No changes were made related to the lock icon functionality.

Possibly related PRs

• Fixed delete button size in asset details & consent record pages #8996: The changes in the PatientConsentRecords.tsx file involve UI updates and logic for managing consent records, which may relate to the overall patient management functionality, but there are no direct code-level connections to the PatientHome component changes.

Suggested reviewers

• rithviknishad

Poem

In the land of hops and shifts,
A model brings its typey gifts.
With locks that change and texts that sing,
Our patient home is blossoming!
So let us cheer, with whiskers bright,
For code that’s clear and feels just right! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

❌ Deploy Preview for care-ohc failed.

Name	Link
🔨 Latest commit	0be85e6
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/672b7e8a3f551c0008aa52b4

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/components/Patient/PatientHome.tsx (1)

892-892: Simplify modal visibility check

The double bang operator (!!) is unnecessary here since modalFor being truthy/falsy is sufficient for the visibility check.

-              show={!!modalFor}
+              show={Boolean(modalFor)}

Also applies to: 894-895

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6b57124 and 5c38ba0.

📒 Files selected for processing (1)

• src/components/Patient/PatientHome.tsx (12 hunks)

🔇 Additional comments (3)

src/components/Patient/PatientHome.tsx (3)

4-4: Type safety improvements look good!

The changes properly introduce strong typing using ShiftingModel across the component, including:

• State management
• Function parameters
• Array mapping
• Null checks

This improves code reliability and maintainability.

Also applies to: 65-65, 76-77, 755-755

---

717-720: Dynamic lock icon implementation matches requirements!

The icon now correctly toggles between locked and unlocked states based on the allow_transfer status, addressing the issue mentioned in #9005.

---

415-415: Internationalization improvements are well implemented!

Text strings have been properly wrapped with the translation function t(), improving the component's internationalization support.

Also applies to: 440-440, 738-738, 918-918, 923-923, 931-931, 947-947, 968-968

[nihal467]

LGTM

[github-actions]

👋 Hi, @nithish1018,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

---

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

cypress.config.ts (1)

Line range hint 14-21: Consider adding TypeScript type definitions for the task parameters.

Since this PR focuses on adding strong types, consider enhancing type safety for the Cypress task definition:

 on("task", {
-  readFileMaybe(filename) {
+  readFileMaybe(filename: string): string | null {
     if (fs.existsSync(filename)) {
       return fs.readFileSync(filename, "utf8");
     }
     return null;
   },
 });

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5c38ba0 and 8c9c4b3.

📒 Files selected for processing (1)

• cypress.config.ts (1 hunks)

🔇 Additional comments (1)

cypress.config.ts (1)

3-3: LGTM! Import statement repositioning is acceptable.

The repositioning of the fs import statement after cypress-split maintains code functionality while following a consistent import order.

[github-actions]

@nithish1018 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌