Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move class keyword manufacturer control to arg #656

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Move class keyword manufacturer control to arg #656

merged 2 commits into from
Jan 29, 2024

Conversation

ohmtech-rdi
Copy link
Owner

This PR moves the definition of the simulator class from the class keyword to arg simulator_class. This makes it more explicit and less weird.

⚠️ This is a breaking change. One will need to change their custom manufacturer defintion from class "Foo" to arg simulator_class "Foo"

@ohmtech-rdi ohmtech-rdi added the enhancement New feature or request label Jan 29, 2024
@ohmtech-rdi ohmtech-rdi self-assigned this Jan 29, 2024
@ohmtech-rdi ohmtech-rdi merged commit 9208c63 into main Jan 29, 2024
21 checks passed
@ohmtech-rdi ohmtech-rdi deleted the erbui-manufacturer-control-simulator-class branch January 29, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ohmtech-rdi ohmtech-rdi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ohmtech-rdi