Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes/font: Fix clock format supporting current timezone #257

Closed
wants to merge 1 commit into from

Conversation

KyongSik-Yoon
Copy link

@KyongSik-Yoon KyongSik-Yoon commented Nov 15, 2021

Font theme has clock format is %I:%M:%S
But it's not recognize current system time zone maybe looks like fixed UTC.
So I update clock format to %T. It's print proper time of current timezone.

@KyongSik-Yoon KyongSik-Yoon changed the title Fix display time format supporting current timezone for default theme (font) Fix clock format supporting current timezone for default theme (font) Nov 15, 2021
@nntoan
Copy link
Member

nntoan commented Jan 10, 2022

@KyongSik-Yoon, that's intentional for general purposes. You can always override it by copying the font theme to the custom directory.

@nntoan nntoan closed this Jan 10, 2022
@akinomyoga akinomyoga reopened this Feb 12, 2023
@akinomyoga akinomyoga changed the title Fix clock format supporting current timezone for default theme (font) themes/font: Fix clock format supporting current timezone Feb 12, 2023
@akinomyoga
Copy link
Contributor

rebased

@RobLoach
Copy link
Contributor

RobLoach commented Sep 1, 2024

Sounds like this can be overriden by setting the THEME_CLOCK_FORMAT variable. I'd recommend closing this one then.

@akinomyoga
Copy link
Contributor

Yeah, I think you are right. I thought it could be also an option to allow users to directly edit the file (since most of the users of OMB do not know how to properly do the things in Bash, and I think it's just fine for those users as far as it works). But we already have descriptions in README, so we do not have to provide another example to change it by modifying the theme file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants