themes/agnoster : pyenv not properly detected/shown #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Pyenv detection to agnoster: - if pyenv is not initialized, fall back to the virtualenv detection - when pyenv is set to a version other than "system", show the version number - when pyenv is in virtulenv mode, also display the virtualenv's name
akinomyoga
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Thank you for your contribution! Could you check the following comments?
Also, you might want to submit similar changes to the upstream speedenator/agnoster-bash.
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
akinomyoga
reviewed
Jul 26, 2023
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
|
I tested both suggestions, seems fine as far as I can tell, so I added both. |
|
Thank you for the comments and suggestions. ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, agnoster relies on
$VIRTUAL_ENVto detect virtualenvs, but it is unreliable when using pyenv. With a named pyenv virtualenv, it properly detects we are in a virtualenv, and sets the prompt as[v] <version>; when using a non-system version, it fails to detect the version ($VIRTUAL_ENVis not set) and hides the python segment.Ideally (I think), pyenv should be treated and displayed somewhat like conda is: when a non system version is used, grab the python version, and when in a virtualenv, show its name and version.
This PR adds Pyenv detection to agnoster:
I'm not particularly proficient with bash, so the whole thing can probably be improved, but as far as I could test, it works. Since I don't use conda, it would likely require some extra testing to see how the two interact and check that it doesn't break the conda display.