Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aliases/package-manager: Add nala aliases #460

Closed
wants to merge 7 commits into from
Closed

aliases/package-manager: Add nala aliases #460

wants to merge 7 commits into from

Conversation

GR3YH4TT3R93
Copy link
Contributor

No description provided.

akinomyoga
akinomyoga reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Could you also consider updating the list alias:package-manager in aliases/README.md?

Although I forgot to request it for dnf in #459, we need to update it. For dnf, I'll update it later.

Also, is there a reason that the aliases for nala are added in this position instead of the bottom of the file?

aliases/package-manager.aliases.bash Outdated Show resolved Hide resolved
@GR3YH4TT3R93
Copy link
Contributor Author

Thank you for your contribution. Could you also consider updating the list alias:package-manager in aliases/README.md?

Although I forgot to request it for dnf in #459, we need to update it. For dnf, I'll update it later.

Also, is there a reason that the aliases for nala are added in this position instead of the bottom of the file?

Done and done!

As for the position of nala, I added it there because Nala is a wrapper for libapt so it felt "right" to have code for associated packages in close proximity.

I can change it if you'd like?

@GR3YH4TT3R93 GR3YH4TT3R93 changed the title added nala aliases to package-manager.aliases.bash add nala aliases to package-manager.aliases.bash Jul 28, 2023
akinomyoga
akinomyoga requested changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the position of nala, I added it there because Nala is a wrapper for libapt so it felt "right" to have code for associated packages in close proximity.

That makes sense. Then, let's keep the current position in this PR.

aliases/README.md Outdated Show resolved Hide resolved
akinomyoga
akinomyoga previously approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Some of the package managers have command names that are different from the names of the package managers. For such package managers, it is good to include the command names in the section headings.

aliases/README.md Outdated Show resolved Hide resolved
aliases/README.md Outdated Show resolved Hide resolved
@akinomyoga akinomyoga changed the title add nala aliases to package-manager.aliases.bash aliases/package-manager: Add nala aliases Jul 30, 2023
akinomyoga
akinomyoga previously approved these changes Jul 30, 2023
View reviewed changes
akinomyoga
akinomyoga previously approved these changes Jul 30, 2023
View reviewed changes
@akinomyoga
Copy link
Contributor

Thank you! I'll later merge it if there are no additional changes.

@GR3YH4TT3R93
Copy link
Contributor Author

GR3YH4TT3R93 commented Jul 30, 2023 •
edited
Loading

Glad to be able to contribute! And sounds good! I'm doing another once over to make absolutely sure everything is perfect right now, hopefully we've gotten everything!

@GR3YH4TT3R93
Copy link
Contributor Author

That was the last one! There should be zero issues with spelling or punctuation now.

I would recommend the contributors of Emerge and Paludis to check over the docs for their package managers to make sure that the info is correct. Especially Paludis was hard to source.

akinomyoga
akinomyoga previously approved these changes Jul 30, 2023
View reviewed changes
@GR3YH4TT3R93
Copy link
Contributor Author

I'm so sorry... I just checked all commands and they now work correctly.

@GR3YH4TT3R93
Copy link
Contributor Author

GR3YH4TT3R93 commented Aug 1, 2023 •
edited
Loading

Nvm, sorry for wasting your time, I'm an idiot who doesn't know how to use git/ github.

@akinomyoga akinomyoga mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga Awaiting requested review from akinomyoga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GR3YH4TT3R93 @akinomyoga