-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
themes: Add theme edsonarios
#481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
Could you prepare the image in the size of about 290x700? You should also update themes/THEMES.md
. They are actually described in CONTRIBUTING.md:
When you add new themes, please also update themes/THEMES.md. The theme needs to have exactly one image of height ~290px and width 600--800px. After your new themes are merged, the list in Themes in the Wiki also needs to be updated.
This background information is non-trivial, so it is better to also include the information in a code comment on the corresponding code. |
Thanks for your comments, I updated my PR with the observations, I hope I have resolved them to your satisfaction. Any other comments, I will be happy to resolve them, thank you very much. |
Thank you for updating. I've pushed additional fixes. Could you check these? |
All good, thanks so much |
show complete work route, show simple git changes and actual time, write commands in new simple line, and show output error.
1887046
to
6068a40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking!
I've merged. Could you also edit the wiki page of themes? |
Sure |
Done, thanks |
Thank you |
My reasons for this new topic.
I usually always install oh-my-bash to start with a new machine or virtual or cloud environment, so I like to have all its functionalities quickly, principally git plugin
My customizations:
I hope that the next time I install oh-my-bash I only need to change the theme name, to have my customizations, thank you very much 😊