Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve VIRTUAL_ENV with double-quotes #541

Merged

Conversation

ScumbagScalawag
Copy link
Contributor

@ScumbagScalawag ScumbagScalawag commented Mar 9, 2024

Without double-quotes, paths with spaces are not resolved correctly and venv name is not displayed correctly.

Before:

└─▪ echo $VIRTUAL_ENV
~/Documents/Path with spaces/env
basename: extra operand ‘spaces/env’
Try 'basename --help' for more information.
┌─()[name][os][±][( main ?:3 ⊘ )][~<Path redacted>]

But with this small change:

┌─(env)[name][os][±][( main ?:3 ⊘ )][~<Path redacted>]
└─▪

Edit: I'm not super familiar with Bash, but I'd recommend a quick once-over to make sure this issue doesn't appear in other places for zork. I only really discoverd this because of novice-level Bash knowledge and ChatGPT xd.

akinomyoga
akinomyoga previously approved these changes Apr 1, 2024
ScumbagScalawag and others added 2 commits April 1, 2024 22:06
Without double-quotes, paths with spaces are not resolved correctly
and venv name is not displayed correctly.
@akinomyoga akinomyoga merged commit 6c1bde9 into ohmybash:master Apr 1, 2024
3 of 4 checks passed
@akinomyoga
Copy link
Contributor

I've applied the same change to the theme mairan and merged the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants