Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes/90210..bobby: Add README.md #559

Merged
merged 24 commits into from
Apr 28, 2024

Conversation

JoseMRT2004
Copy link
Contributor

I'm adding readmes so that users can see what the themes are like without having to enter a file, I'm also adding a quality time of the theme.

I plan to do it with everyone but I wanted the approval to continue working !

akinomyoga
akinomyoga previously approved these changes Apr 25, 2024
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to do it with everyone but I wanted the approval to continue working !

Much appreciated.

@JoseMRT2004 JoseMRT2004 marked this pull request as ready for review April 25, 2024 04:32
@JoseMRT2004
Copy link
Contributor Author

So let's get to work ❤️

@JoseMRT2004 JoseMRT2004 deleted the Themes-readme branch April 25, 2024 04:43
@JoseMRT2004 JoseMRT2004 restored the Themes-readme branch April 25, 2024 04:46
@JoseMRT2004
Copy link
Contributor Author

Well, thinking about it, you can merge these changes and then send the others

@JoseMRT2004 JoseMRT2004 reopened this Apr 25, 2024
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

themes/90210/README.md Outdated Show resolved Hide resolved
themes/90210/README.md Outdated Show resolved Hide resolved
themes/90210/README.md Outdated Show resolved Hide resolved
themes/axin/README.md Outdated Show resolved Hide resolved
themes/bakke/README.md Outdated Show resolved Hide resolved
themes/bakke/README.md Outdated Show resolved Hide resolved
themes/binaryanomaly/README.md Outdated Show resolved Hide resolved
@JoseMRT2004
Copy link
Contributor Author

Thanks for the advice, they contribute a lot and the feedback. Tomorrow I will fix it here in the DR, it is 2:00 am

Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you resolve those errors found in CI?

themes/bakke/README.md:
	10: Trailing whitespace
themes/binaryanomaly/README.md:
	17: Trailing whitespace
	19: Trailing whitespace

3 errors found

themes/binaryanomaly/README.md Outdated Show resolved Hide resolved
themes/bobby/README.md Outdated Show resolved Hide resolved
JoseMRT2004 and others added 3 commits April 25, 2024 23:23
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
@JoseMRT2004
Copy link
Contributor Author

They were those empty lines, That's all

@akinomyoga
Copy link
Contributor

CI is still failing: https://github.com/ohmybash/oh-my-bash/actions/runs/8842695616/job/24281742454?pr=559

Those lines have extra whitespace characters at the end of the lines. Please remove those whitespace characters.

themes/axin/README.md Outdated Show resolved Hide resolved
themes/axin/README.md Outdated Show resolved Hide resolved
themes/binaryanomaly/README.md Outdated Show resolved Hide resolved
themes/bakke/README.md Show resolved Hide resolved
themes/90210/README.md Outdated Show resolved Hide resolved
JoseMRT2004 and others added 3 commits April 26, 2024 08:51
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
themes/bobby/README.md Outdated Show resolved Hide resolved
@akinomyoga akinomyoga changed the title themes/....:add readme themes/90210..bobby: add README.md Apr 28, 2024
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
@akinomyoga akinomyoga changed the title themes/90210..bobby: add README.md themes/90210..bobby: Add README.md Apr 28, 2024
akinomyoga
akinomyoga previously approved these changes Apr 28, 2024
@akinomyoga akinomyoga merged commit 0ec9c0c into ohmybash:master Apr 28, 2024
4 checks passed
@akinomyoga
Copy link
Contributor

Thanks!

@JoseMRT2004 JoseMRT2004 deleted the Themes-readme branch April 28, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants