-
-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
themes/90210..bobby: Add README.md #559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to do it with everyone but I wanted the approval to continue working !
Much appreciated.
So let's get to work ❤️ |
Well, thinking about it, you can merge these changes and then send the others |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Thanks for the advice, they contribute a lot and the feedback. Tomorrow I will fix it here in the DR, it is 2:00 am |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you resolve those errors found in CI?
themes/bakke/README.md:
10: Trailing whitespace
themes/binaryanomaly/README.md:
17: Trailing whitespace
19: Trailing whitespace
3 errors found
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
They were those empty lines, That's all |
CI is still failing: https://github.com/ohmybash/oh-my-bash/actions/runs/8842695616/job/24281742454?pr=559 Those lines have extra whitespace characters at the end of the lines. Please remove those whitespace characters. |
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Thanks! |
I'm adding readmes so that users can see what the themes are like without having to enter a file, I'm also adding a quality time of the theme.
I plan to do it with everyone but I wanted the approval to continue working !