plugins/asdf: Add asdf extendable version manager plugin
#593
+73
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobLoach
changed the title
asdf pluginasdf extendable version manager plugin
akinomyoga
requested changes
Aug 26, 2024
There was a problem hiding this comment.
It's roughly based off of the original pull request, moves to the bash syntax, and allows checking for the
ASDF_DIRvariable before hitting the file system.
Thank you. Could you mention the original author (https://github.com/prodrigues1912) and URL of PR #310 in the code comment around the top of asdf.plugin.sh? Since it will not remain in the git history, we need to leave the information manually.
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
|
Thanks a lot for the review, I'll fix these up. |
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
RobLoach
commented
Aug 27, 2024
RobLoach
commented
Aug 27, 2024
|
I didn't consider the commit message format here, so when merging, feel free to squash on merge. Thanks a lot for the reviews. |
akinomyoga
approved these changes
Aug 28, 2024
|
Thank you. |
|
Thank you so much for the reviews and merge 👍 ... Happy to have this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a plugin to load the asdf version manager through oh-my-bash. It's roughly based off of the original pull request, moves to the bash syntax, and allows checking for the
ASDF_DIRvariable before hitting the file system.