Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commonize special polynomials #51

Closed
ohno opened this issue Apr 21, 2024 · 2 comments
Closed

Commonize special polynomials #51

ohno opened this issue Apr 21, 2024 · 2 comments

Comments

@ohno
Copy link
Owner

ohno commented Apr 21, 2024

We currently prioritize each model being independent and self-contained. Some orthogonal polynomials can be made common. Reconsider whether the code should be common before updating to v1.0.0. This issue is related to #49.

@ohno ohno added this to the v1.0.0 milestone Apr 21, 2024
@lhapp27
Copy link
Collaborator

lhapp27 commented Apr 24, 2024

I think the same holds true also for the spherical harmonics. All (spherical symmetric) 3D problems they can use the same common function.

@ohno
Copy link
Owner Author

ohno commented Jun 8, 2024

I gave priority to that all member functions are self-contained in each file.

Also, Commonization of spherical harmonic functions, etc. does not change the Public API. Therefore, commonization can be done after the release of a major version 1.0.0 if we need.

@ohno ohno closed this as completed Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants