Clarified nr of bound states vs max quantum nr in PoschlTeller #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry for not updating the fork before merging, hence leading to "conflicts". |
ohno
requested changes
Jun 8, 2024
docs/src/PoschlTeller.md
Outdated
| ```@docs; canonical=false | ||
| Antique.nₘₐₓ(::PoschlTeller) | ||
| ``` | ||
| Note that the number of bound states is `nₘₐₓ + 1`, since we count the ground state from `n=0`. |
There was a problem hiding this comment.
Please write this line into the docstring.
docs/src/PoschlTeller.md
Outdated
|
|
||
| ```@repl PT | ||
| nₘₐₓ(PT) | ||
| ``` | ||
| Note that the number of bound states is `nₘₐₓ + 1`, since we count the ground state from `n=0`. |
src/PoschlTeller.jl
Outdated
There was a problem hiding this comment.
I would like to discard the commit to this file. We don't need change this file if 0 <= n <= n_max has been correct. Please pull latest version and update the docstrings. No conflicts will occur.
Closed
|
Please see 2 pages:
The changes are as follows:
I tthink all you have to do is change the docstrings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I clarified the difference between the number of bound states and the maximum quantum number in the documentation for the Pöschl-Teller model. The same issue should exist for models in which we count
nfrom 0, and which have a finite number of bound states, i.e. the Morse potential.